This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7125

tests: rename stopped and started variables to reflect times
ClosedPublic

Authored by indygreg on Oct 17 2019, 1:12 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGae91e4e4c9b0: tests: rename stopped and started variables to reflect times
Summary

In preparation for introducing more variables that will have
similar names.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 17 2019, 1:12 AM
pulkit accepted this revision.Nov 11 2019, 6:47 AM
This revision is now accepted and ready to land.Nov 11 2019, 6:47 AM

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (12 lines)

Diff 18012

tests/run-tests.py

def startTest(self, test): def startTest(self, test):
super(TestResult, self).startTest(test) super(TestResult, self).startTest(test)
# os.times module computes the user time and system time spent by # os.times module computes the user time and system time spent by
# child's processes along with real elapsed time taken by a process. # child's processes along with real elapsed time taken by a process.
# This module has one limitation. It can only work for Linux user # This module has one limitation. It can only work for Linux user
# and not for Windows. # and not for Windows.
test.started = os.times() test.started_times = os.times()
if self._firststarttime is None: # thread racy but irrelevant if self._firststarttime is None: # thread racy but irrelevant
self._firststarttime = test.started[4] self._firststarttime = test.started_times[4]
def stopTest(self, test, interrupted=False): def stopTest(self, test, interrupted=False):
super(TestResult, self).stopTest(test) super(TestResult, self).stopTest(test)
test.stopped = os.times() test.stopped_times = os.times()
starttime = test.started starttime = test.started_times
endtime = test.stopped endtime = test.stopped_times
origin = self._firststarttime origin = self._firststarttime
self.times.append( self.times.append(
( (
test.name, test.name,
endtime[2] - starttime[2], # user space CPU time endtime[2] - starttime[2], # user space CPU time
endtime[3] - starttime[3], # sys space CPU time endtime[3] - starttime[3], # sys space CPU time
endtime[4] - starttime[4], # real time endtime[4] - starttime[4], # real time
starttime[4] - origin, # start date in run context starttime[4] - origin, # start date in run context