Page MenuHomePhabricator

tests: use time.time() for relative start and stop times
ClosedPublic

Authored by indygreg on Oct 17 2019, 1:12 AM.

Details

Summary

os.times() does not work on Windows. This was resulting in the
test start, stop, and duration times being reported as 0.

This commit swaps in time.time() for wall clock measurements.

This isn't ideal, as time.time() is not monotonic. But Python 2.7
does not have a monotonic timer that works on Windows. So it is
the best we have which is trivially usable. And test times aren't
terribly important, so variances due to clock skew are arguably
acceptable.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 17 2019, 1:12 AM
pulkit accepted this revision.Mon, Nov 11, 6:48 AM
This revision is now accepted and ready to land.Mon, Nov 11, 6:48 AM