Page MenuHomePhabricator

rebase: allow rebasing obsolete commit without successor
Needs RevisionPublic

Authored by martinvonz on Oct 25 2019, 8:48 PM.


Group Reviewers

When trying to rebase an obsolete whose successors are also all
obsolete, we would skip it and tell the user that it would have caused
divergence. That is not correct. We could just change the message, but
I don't see any harm in rebasing such commits. It even seems like a
reasonable way to make it not obsolete. So this patch makes that type
of rebase allowed.

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 25 2019, 8:48 PM

That is not necessarly True, If the changeset is pruned, but successors of a public changeset, rebasing it would create phase-divergence. @khanchi97 fixed similar cases in September.

Overall, we should migrate the rebase code to use the precheck logic in rewrite util (and make sure things are well covered there).

One can read more about current Sushil work in this area here:

baymax requested changes to this revision.Jan 30 2020, 1:06 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.


This revision now requires changes to proceed.Jan 30 2020, 1:06 PM