Page MenuHomePhabricator

tests: fix 'if False' statements flagged by check-code
ClosedPublic

Authored by simpkins on Jul 12 2017, 11:18 PM.

Details

Summary

The check-code test in the upstream mercurial repository was recently updated
to start complaining about "if False" statements. Two locations in fb-hgext
had this issue.

These both look to be copy-and-pastes of the same function, unfortunately.
That should probably be cleaned up too, but I'll leave that for a separate diff
for now.

Test Plan

Confirmed the test-check-code test passes now.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

simpkins created this revision.Jul 12 2017, 11:18 PM
quark accepted this revision.Jul 13 2017, 12:19 AM
This revision is now accepted and ready to land.Jul 13 2017, 12:19 AM
This revision was automatically updated to reflect the committed changes.