This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7202

fsmonitor: remove pywatchman from exclusion rule
ClosedPublic

Authored by indygreg on Nov 2 2019, 6:03 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG2247bf3cec76: fsmonitor: remove pywatchman from exclusion rule
Summary

The recently vendored pywatchman code base is now formatted
with black. We can now remove pywatchman from our black
exclusion rule.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 2 2019, 6:03 PM
indygreg added a commit: rHG2247bf3cec76: fsmonitor: remove pywatchman from exclusion rule.Nov 4 2019, 11:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG2247bf3cec76: fsmonitor: remove pywatchman from exclusion rule (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mblack.toml (1 line)
Mcontrib/examples/fix.hgrc (2 lines)
Mtests/test-check-format.t (2 lines)

Diff 17519

black.toml

[tool.black] [tool.black]
line-length = 80 line-length = 80
exclude = ''' exclude = '''
build/ build/
| wheelhouse/ | wheelhouse/
| dist/ | dist/
| packages/ | packages/
| \.hg/ | \.hg/
| \.mypy_cache/ | \.mypy_cache/
| \.venv/ | \.venv/
| mercurial/thirdparty/ | mercurial/thirdparty/
| hgext/fsmonitor/pywatchman/
| contrib/python-zstandard/ | contrib/python-zstandard/
''' '''
skip-string-normalization = true skip-string-normalization = true
quiet = true quiet = true

contrib/examples/fix.hgrc

[fix] [fix]
clang-format:command = clang-format --style file -i clang-format:command = clang-format --style file -i
clang-format:pattern = (**.c or **.cc or **.h) and not "listfile:contrib/clang-format-ignorelist" clang-format:pattern = (**.c or **.cc or **.h) and not "listfile:contrib/clang-format-ignorelist"
rustfmt:command = rustfmt {rootpath} rustfmt:command = rustfmt {rootpath}
rustfmt:pattern = set:**.rs rustfmt:pattern = set:**.rs
black:command = black --config=black.toml - black:command = black --config=black.toml -
black:pattern = set:**.py - hgext/fsmonitor/pywatchman/** - mercurial/thirdparty/** - "contrib/python-zstandard/**" black:pattern = set:**.py - mercurial/thirdparty/** - "contrib/python-zstandard/**"

tests/test-check-format.t

#require black #require black
$ cd $RUNTESTDIR/.. $ cd $RUNTESTDIR/..
$ black --config=black.toml --check --diff `hg files 'set:**.py - hgext/fsmonitor/pywatchman/** - mercurial/thirdparty/** - "contrib/python-zstandard/**"'` $ black --config=black.toml --check --diff `hg files 'set:**.py - mercurial/thirdparty/** - "contrib/python-zstandard/**"'`