This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7221

hghave: fix bytes/string issue on Python 3
ClosedPublic

Authored by indygreg on Nov 4 2019, 4:20 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 4 2019, 4:20 PM
pulkit accepted this revision.Nov 5 2019, 4:15 AM
This revision is now accepted and ready to land.Nov 5 2019, 4:15 AM
marmoute added a subscriber: marmoute.Apr 22 2020, 11:58 AM

Baymax does not catch stuff in Accepted state, but this diff is 6 months old, so resubmit if still relevant.

indygreg added a subscriber: indygreg.Aug 8 2020, 4:56 PM

A similar patch already landed. I'm going to commandeer and close.

indygreg added a reviewer: durin42.Aug 8 2020, 4:56 PM
indygreg commandeered this revision.
indygreg closed this revision.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 17536

tests/hghave.py

@check('black', 'the black formatter for python') @check('black', 'the black formatter for python')
def has_black(): def has_black():
blackcmd = 'black --version' blackcmd = 'black --version'
version_regex = b'black, version ([0-9a-b.]+)' version_regex = b'black, version ([0-9a-b.]+)'
version = matchoutput(blackcmd, version_regex) version = matchoutput(blackcmd, version_regex)
sv = distutils.version.StrictVersion sv = distutils.version.StrictVersion
return version and sv(version.group(1)) >= sv('19.10b0') return version and sv(_strpath(version.group(1))) >= sv('19.10b0')