This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7236

repoview: wrap changelog class when filtering
ClosedPublic

Authored by martinvonz on Nov 5 2019, 7:59 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG625e7d1ffd1c: repoview: wrap changelog class when filtering
rHGdc34c78d1c01: repoview: wrap changelog class when filtering
Summary

The class doesn't yet do anything. I'll move the filter-aware
overrides from the changelog class over one by one to this class in
coming patches. That will leave the changelog class simpler and will
centralize more of the filtering logic to repoview. I could not
measure any performance difference.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/repoview.py (6 lines)

Diff 17586

mercurial/repoview.py

if visibilityexceptions: if visibilityexceptions:
return func(repo.unfiltered, visibilityexceptions) return func(repo.unfiltered, visibilityexceptions)
repo.filteredrevcache[filtername] = func(repo.unfiltered()) repo.filteredrevcache[filtername] = func(repo.unfiltered())
return repo.filteredrevcache[filtername] return repo.filteredrevcache[filtername]
def wrapchangelog(unfichangelog, filteredrevs): def wrapchangelog(unfichangelog, filteredrevs):
cl = copy.copy(unfichangelog) cl = copy.copy(unfichangelog)
cl.filteredrevs = filteredrevs cl.filteredrevs = filteredrevs
class filteredchangelog(cl.__class__):
pass
cl.__class__ = filteredchangelog
return cl return cl
class repoview(object): class repoview(object):
"""Provide a read/write view of a repo through a filtered changelog """Provide a read/write view of a repo through a filtered changelog
This object is used to access a filtered version of a repository without This object is used to access a filtered version of a repository without
altering the original repository object itself. We can not alter the altering the original repository object itself. We can not alter the
original object for two main reasons: original object for two main reasons: