This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7250

revlog: move tiprev() from changelog up to revlog
ClosedPublic

Authored by martinvonz on Nov 5 2019, 8:01 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGec7ba79bf3db: revlog: move tiprev() from changelog up to revlog
rHG2860f6019b85: revlog: move tiprev() from changelog up to revlog
Summary

This makes the changelog override simpler and it seems more
consistent.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (5 lines)
Mmercurial/revlog.py (5 lines)

Diff 17580

mercurial/changelog.py

self._realopener = opener self._realopener = opener
self._delayed = False self._delayed = False
self._delaybuf = None self._delaybuf = None
self._divert = False self._divert = False
self.filteredrevs = frozenset() self.filteredrevs = frozenset()
self._copiesstorage = opener.options.get(b'copies-storage') self._copiesstorage = opener.options.get(b'copies-storage')
def tiprev(self): def tiprev(self):
"""filtered version of revlog.tiprev"""
for i in pycompat.xrange(len(self) - 1, -2, -1): for i in pycompat.xrange(len(self) - 1, -2, -1):
if i not in self.filteredrevs: if i not in self.filteredrevs:
return i return i
def tip(self):
"""filtered version of revlog.tip"""
return self.node(self.tiprev())
def __contains__(self, rev): def __contains__(self, rev):
"""filtered version of revlog.__contains__""" """filtered version of revlog.__contains__"""
return 0 <= rev < len(self) and rev not in self.filteredrevs return 0 <= rev < len(self) and rev not in self.filteredrevs
def __iter__(self): def __iter__(self):
"""filtered version of revlog.__iter__""" """filtered version of revlog.__iter__"""
if len(self.filteredrevs) == 0: if len(self.filteredrevs) == 0:
return revlog.revlog.__iter__(self) return revlog.revlog.__iter__(self)

mercurial/revlog.py

else: else:
if self._inline: if self._inline:
func = self._indexfp func = self._indexfp
else: else:
func = self._datafp func = self._datafp
with func() as fp: with func() as fp:
yield fp yield fp
def tiprev(self):
return len(self.index) - 1
def tip(self): def tip(self):
return self.node(len(self.index) - 1) return self.node(self.tiprev())
def __contains__(self, rev): def __contains__(self, rev):
return 0 <= rev < len(self) return 0 <= rev < len(self)
def __len__(self): def __len__(self):
return len(self.index) return len(self.index)
def __iter__(self): def __iter__(self):