Page MenuHomePhabricator

[RFC] repoview: add a "filter" that just disallows walking to heads
Needs RevisionPublic

Authored by martinvonz on Nov 6 2019, 12:01 PM.

Details

Reviewers
durin42
baymax
Group Reviewers
hg-reviewers
Summary

This can let us find bugs where we think it shouldn't matter whether
we're using an unfiltered or filtered repo. We could then get a repo
that is using this new "filter" and if the code ends up trying to walk
the graph towards the changelog children, we would notice that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Nov 6 2019, 12:01 PM
martinvonz updated this revision to Diff 18048.Nov 12 2019, 4:33 PM

Can you elaborate on what this changeset is about ? the description is a bit… short;-)

martinvonz edited the summary of this revision. (Show Details)Nov 12 2019, 5:21 PM

Can you elaborate on what this changeset is about ? the description is a bit… short;-)

Done.

durin42 accepted this revision as: durin42.Nov 13 2019, 6:10 PM
durin42 added a subscriber: durin42.

I'm a big fan of this idea. I'd probably land it if there were some obvious usecases as child patches. :)

baymax requested changes to this revision.Feb 21 2020, 3:50 AM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Feb 21 2020, 3:50 AM