( )⚙ D7445 doc: don't use mutable default arguments

This is an archive of the discontinued Mercurial Phabricator instance.

doc: don't use mutable default arguments
ClosedPublic

Authored by indygreg on Nov 16 2019, 3:08 PM.

Details

Summary

It appears our mutable default arguments checker doesn't find
arguments not on the first line of a function definition :(

The arguments aren't used, so the default value is irrelevant.

I found this when blackening this script in a future commit.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Nov 16 2019, 3:08 PM
pulkit accepted this revision.Nov 18 2019, 11:11 AM
This revision is now accepted and ready to land.Nov 18 2019, 11:11 AM
This revision was automatically updated to reflect the committed changes.