( )⚙ D7448 tests: check for Windows line endings

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7448

tests: check for Windows line endings
ClosedPublic

Authored by indygreg on Nov 16 2019, 3:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf0b33e5f0cf4: tests: check for Windows line endings
Summary

We shouldn't generally be using Windows line endings in files
under version control. I've accidentally committed a few files
with Windows line endings recently. So let's add a test for
this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 16 2019, 3:08 PM
pulkit accepted this revision.Nov 18 2019, 11:13 AM
This revision is now accepted and ready to land.Nov 18 2019, 11:13 AM
indygreg added a commit: rHGf0b33e5f0cf4: tests: check for Windows line endings.Nov 18 2019, 11:50 AM
Closed by commit rHGf0b33e5f0cf4: tests: check for Windows line endings (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-code.t (6 lines)

Diff 18216

tests/test-check-code.t

> mercurial/osutil.py \ > mercurial/osutil.py \
> mercurial/parsers.py \ > mercurial/parsers.py \
> mercurial/zstd.py > mercurial/zstd.py
[1] [1]
Keep python3 tests sorted: Keep python3 tests sorted:
$ sort < contrib/python3-whitelist > $TESTTMP/py3sorted $ sort < contrib/python3-whitelist > $TESTTMP/py3sorted
$ cmp contrib/python3-whitelist $TESTTMP/py3sorted || echo 'Please sort passing tests!' $ cmp contrib/python3-whitelist $TESTTMP/py3sorted || echo 'Please sort passing tests!'
Keep Windows line endings in check
$ hg files 'set:eol(dos)'
contrib/win32/hg.bat
contrib/win32/mercurial.ini