This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7473

localrepo: add some basic comment for block in __getitem__
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG9c83d28776af: localrepo: add some basic comment for block in __getitem__
rHG7d6465eda585: localrepo: add some basic comment for block in __getitem__
Summary

There are different early processing before getting to the core of the function.
We highlight that fact.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (5 lines)

Diff 18325

mercurial/localrepo.py

return matchmod.intersectmatchers(match, self._narrowmatch) return matchmod.intersectmatchers(match, self._narrowmatch)
return self._narrowmatch return self._narrowmatch
def setnarrowpats(self, newincludes, newexcludes): def setnarrowpats(self, newincludes, newexcludes):
narrowspec.save(self, newincludes, newexcludes) narrowspec.save(self, newincludes, newexcludes)
self.invalidate(clearfilecache=True) self.invalidate(clearfilecache=True)
def __getitem__(self, changeid): def __getitem__(self, changeid):
# dealing with special cases
if changeid is None: if changeid is None:
return context.workingctx(self) return context.workingctx(self)
if isinstance(changeid, context.basectx): if isinstance(changeid, context.basectx):
return changeid return changeid
# dealing with multiple revisions
if isinstance(changeid, slice): if isinstance(changeid, slice):
# wdirrev isn't contiguous so the slice shouldn't include it # wdirrev isn't contiguous so the slice shouldn't include it
return [ return [
self[i] self[i]
for i in pycompat.xrange(*changeid.indices(len(self))) for i in pycompat.xrange(*changeid.indices(len(self)))
if i not in self.changelog.filteredrevs if i not in self.changelog.filteredrevs
] ]
# dealing with arbitrary values
try: try:
if isinstance(changeid, int): if isinstance(changeid, int):
node = self.changelog.node(changeid) node = self.changelog.node(changeid)
rev = changeid rev = changeid
elif changeid == b'null': elif changeid == b'null':
node = nullid node = nullid
rev = nullrev rev = nullrev
elif changeid == b'tip': elif changeid == b'tip':