This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7481

localrepo: recognize trivial "null" queries in `anyrev`
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:20 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG09409a3fc3cc: localrepo: recognize trivial "null" queries in `anyrev`
rHGc0e04f07a2d4: localrepo: recognize trivial "null" queries in `anyrev`
Summary

Bypassing the revset logic for trivial "null" queries means we can avoid to
trigger the filtering logic in some cases.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Nov 22 2019, 4:20 AM
indygreg accepted this revision.Nov 22 2019, 10:55 PM
This revision is now accepted and ready to land.Nov 22 2019, 10:55 PM
marmoute added a commit: rHGc0e04f07a2d4: localrepo: recognize trivial "null" queries in `anyrev`.Nov 22 2019, 11:07 PM
Closed by commit rHGc0e04f07a2d4: localrepo: recognize trivial "null" queries in `anyrev` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Nov 23 2019, 11:57 PM

+ if specs == [b'null']:
+ return revset.baseset([nullrev])

This breaks --config revsetalias.null=<whatever>. Nobody would care, but
I don't know why we're so hard to optimize -r null query.

marmoute added a comment.Nov 24 2019, 6:24 AM
In D7481#110524, @yuja wrote:

+ if specs == [b'null']:
+ return revset.baseset([nullrev])

This breaks --config revsetalias.null=<whatever>. Nobody would care, but
I don't know why we're so hard to optimize -r null query.

I woudl says that changing null (like changing .) is calling for troubles and I would not worries.

optimising null is a good intermediate steps on the path to optimizing .; it also seems a possibly common request for automation.

Revision Contents
Changeset List

Diff 18348

mercurial/localrepo.py

def anyrevs(self, specs, user=False, localalias=None): def anyrevs(self, specs, user=False, localalias=None):
'''Find revisions matching one of the given revsets. '''Find revisions matching one of the given revsets.
Revset aliases from the configuration are not expanded by default. To Revset aliases from the configuration are not expanded by default. To
expand user aliases, specify ``user=True``. To provide some local expand user aliases, specify ``user=True``. To provide some local
definitions overriding user aliases, set ``localalias`` to definitions overriding user aliases, set ``localalias`` to
``{name: definitionstring}``. ``{name: definitionstring}``.
''' '''
if specs == [b'null']:
return revset.baseset([nullrev])
if user: if user:
m = revset.matchany( m = revset.matchany(
self.ui, self.ui,
specs, specs,
lookup=revset.lookupfn(self), lookup=revset.lookupfn(self),
localalias=localalias, localalias=localalias,
) )
else: else:

tests/test-repo-filters-tiptoe.t

tests tests
----- -----
Getting the node of `null` Getting the node of `null`
$ hg log -r null -T "{node}\n" $ hg log -r null -T "{node}\n"
debug.filters: computing revision filter for "visible"
0000000000000000000000000000000000000000 0000000000000000000000000000000000000000
Getting basic changeset inforation about `null` Getting basic changeset inforation about `null`
$ hg log -r null -T "{node}\n{date}\n" $ hg log -r null -T "{node}\n{date}\n"
debug.filters: computing revision filter for "visible" debug.filters: computing revision filter for "visible"
0000000000000000000000000000000000000000 0000000000000000000000000000000000000000
0.00 0.00