This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7474

localrepo: extract handling of some special value in __getitem__
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6237cb11753e: localrepo: extract handling of some special value in __getitem__
rHGb7d0aa525435: localrepo: extract handling of some special value in __getitem__
Summary

The value "null" will always be present in a repository. So this lookup should
always succeed and do not need to be in the general try/catch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (6 lines)

Diff 18326

mercurial/localrepo.py

if isinstance(changeid, slice): if isinstance(changeid, slice):
# wdirrev isn't contiguous so the slice shouldn't include it # wdirrev isn't contiguous so the slice shouldn't include it
return [ return [
self[i] self[i]
for i in pycompat.xrange(*changeid.indices(len(self))) for i in pycompat.xrange(*changeid.indices(len(self)))
if i not in self.changelog.filteredrevs if i not in self.changelog.filteredrevs
] ]
# dealing with some special values
if changeid == b'null':
return context.changectx(self, nullrev, nullid)
# dealing with arbitrary values # dealing with arbitrary values
try: try:
if isinstance(changeid, int): if isinstance(changeid, int):
node = self.changelog.node(changeid) node = self.changelog.node(changeid)
rev = changeid rev = changeid
elif changeid == b'null':
node = nullid
rev = nullrev
elif changeid == b'tip': elif changeid == b'tip':
node = self.changelog.tip() node = self.changelog.tip()
rev = self.changelog.rev(node) rev = self.changelog.rev(node)
elif changeid == b'.': elif changeid == b'.':
# this is a hack to delay/avoid loading obsmarkers # this is a hack to delay/avoid loading obsmarkers
# when we know that '.' won't be hidden # when we know that '.' won't be hidden
node = self.dirstate.p1() node = self.dirstate.p1()
rev = self.unfiltered().changelog.rev(node) rev = self.unfiltered().changelog.rev(node)