This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7475

localrepo: extract handling of some special value in __getitem__
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG657bdb724b47: localrepo: extract handling of some special value in __getitem__
rHG8e2df30694de: localrepo: extract handling of some special value in __getitem__
Summary

The value "tip" should always be accessible, otherwise there is some problematic
bug in the lower level. So we can access this outside of the general try/catch.
If it fails some wider and actual big is in play.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (8 lines)

Diff 18327

mercurial/localrepo.py

self[i] self[i]
for i in pycompat.xrange(*changeid.indices(len(self))) for i in pycompat.xrange(*changeid.indices(len(self)))
if i not in self.changelog.filteredrevs if i not in self.changelog.filteredrevs
] ]
# dealing with some special values # dealing with some special values
if changeid == b'null': if changeid == b'null':
return context.changectx(self, nullrev, nullid) return context.changectx(self, nullrev, nullid)
if changeid == b'tip':
node = self.changelog.tip()
rev = self.changelog.rev(node)
return context.changectx(self, rev, node)
# dealing with arbitrary values # dealing with arbitrary values
try: try:
if isinstance(changeid, int): if isinstance(changeid, int):
node = self.changelog.node(changeid) node = self.changelog.node(changeid)
rev = changeid rev = changeid
elif changeid == b'tip':
node = self.changelog.tip()
rev = self.changelog.rev(node)
elif changeid == b'.': elif changeid == b'.':
# this is a hack to delay/avoid loading obsmarkers # this is a hack to delay/avoid loading obsmarkers
# when we know that '.' won't be hidden # when we know that '.' won't be hidden
node = self.dirstate.p1() node = self.dirstate.p1()
rev = self.unfiltered().changelog.rev(node) rev = self.unfiltered().changelog.rev(node)
elif len(changeid) == 20: elif len(changeid) == 20:
try: try:
node = changeid node = changeid