This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7480

localrepo: also fastpath `nullrev` in __getitem__
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG998dd6a8fd98: localrepo: also fastpath `nullrev` in __getitem__
rHG099e96103085: localrepo: also fastpath `nullrev` in __getitem__
Summary

As explained earlier, nullrev will exist in all repository, we do not need any
special checking.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 18332

mercurial/localrepo.py

# wdirrev isn't contiguous so the slice shouldn't include it # wdirrev isn't contiguous so the slice shouldn't include it
return [ return [
self[i] self[i]
for i in pycompat.xrange(*changeid.indices(len(self))) for i in pycompat.xrange(*changeid.indices(len(self)))
if i not in self.changelog.filteredrevs if i not in self.changelog.filteredrevs
] ]
# dealing with some special values # dealing with some special values
if changeid == b'null': if changeid == b'null' or changeid == nullrev:
return context.changectx(self, nullrev, nullid) return context.changectx(self, nullrev, nullid)
if changeid == b'tip': if changeid == b'tip':
node = self.changelog.tip() node = self.changelog.tip()
rev = self.changelog.rev(node) rev = self.changelog.rev(node)
return context.changectx(self, rev, node) return context.changectx(self, rev, node)
# dealing with arbitrary values # dealing with arbitrary values
try: try: