This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7486

locarepo: also fastpath `nullid` lookup in __getitem__
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:20 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG3fd6ec54704c: locarepo: also fastpath `nullid` lookup in __getitem__
rHGc9d1e2ec1e2e: locarepo: also fastpath `nullid` lookup in __getitem__
Summary

We already use that fastpath for "null" and nullrev, using it for nullid
is similar.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 18372

mercurial/localrepo.py

# wdirrev isn't contiguous so the slice shouldn't include it # wdirrev isn't contiguous so the slice shouldn't include it
return [ return [
self[i] self[i]
for i in pycompat.xrange(*changeid.indices(len(self))) for i in pycompat.xrange(*changeid.indices(len(self)))
if i not in self.changelog.filteredrevs if i not in self.changelog.filteredrevs
] ]
# dealing with some special values # dealing with some special values
if changeid == b'null' or changeid == nullrev: if changeid == b'null' or changeid == nullrev or changeid == nullid:
return context.changectx(self, nullrev, nullid, maybe_filtered=False) return context.changectx(self, nullrev, nullid, maybe_filtered=False)
if changeid == b'tip': if changeid == b'tip':
node = self.changelog.tip() node = self.changelog.tip()
rev = self.changelog.rev(node) rev = self.changelog.rev(node)
return context.changectx(self, rev, node) return context.changectx(self, rev, node)
# dealing with arbitrary values # dealing with arbitrary values
try: try: