This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7508

relnotes: add note about changes to match.{explicit,reverse}dir
ClosedPublic

Authored by martinvonz on Nov 22 2019, 2:09 PM.

Details

Reviewers
dlax
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc8e9a3636abe: relnotes: add note about changes to match.{explicit,reverse}dir
rHG32aa6cefb8f3: relnotes: add note about changes to match.{explicit,reverse}dir

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 22 2019, 2:09 PM
dlax added a subscriber: dlax.Nov 22 2019, 3:14 PM
dlax added inline comments.
relnotes/next
22

simple -> simply?

martinvonz updated this revision to Diff 18322.Nov 22 2019, 6:01 PM
martinvonz marked an inline comment as done.Nov 22 2019, 6:01 PM
dlax accepted this revision.Nov 23 2019, 3:25 AM
pulkit accepted this revision.Nov 25 2019, 10:29 AM
This revision is now accepted and ready to land.Nov 25 2019, 10:29 AM

Revision Contents
Changeset List

PathPackages
Mrelnotes/next (6 lines)

Diff 18389

relnotes/next

but it still indented the first line even if it was empty. It no longer does but it still indented the first line even if it was empty. It no longer does
that. that.
== Backwards Compatibility Changes == == Backwards Compatibility Changes ==
== Internal API Changes == == Internal API Changes ==
* Matcher instances no longer have a `explicitdir` property. Consider
rewriting your code to use `repo.wvfs.isdir()` and/or
`ctx.hasdir()` instead. Also, the `traversedir` property is now
also called when only `explicitdir` used to be called. That may
mean that you can simply remove the use of `explicitdir` if you
dlaxUnsubmitted
Done

simple -> simply?

dlax: simple -> simply?
were already using `traversedir`.