Page MenuHomePhabricator

webutil: add missing argument to join()
ClosedPublic

Authored by mharbison72 on Sat, Nov 23, 11:06 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Sat, Nov 23, 11:06 PM
dlax accepted this revision.Sun, Nov 24, 3:50 AM
dlax added a subscriber: dlax.

Looks like dead code

In D7516#110537, @dlax wrote:

Looks like dead code

It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in join(). @yuja?

yuja added a comment.Sun, Nov 24, 10:07 AM
It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here).  It also might be a WIP, given the comment in `join()`.  @yuja?

{sessionvars} (with no %template) would crash without this change.
Queued, thanks.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.