This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7516

webutil: add missing argument to join()
ClosedPublic

Authored by mharbison72 on Nov 23 2019, 11:06 PM.

Details

Reviewers
dlax
Group Reviewers
hg-reviewers
Commits
rHG371765e775a2: webutil: add missing argument to join()

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Nov 23 2019, 11:06 PM
dlax accepted this revision.Nov 24 2019, 3:50 AM
dlax added a subscriber: dlax.

Looks like dead code

mharbison72 added a subscriber: yuja.Nov 24 2019, 9:17 AM
In D7516#110537, @dlax wrote:

Looks like dead code

It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in join(). @yuja?

yuja added a comment.Nov 24 2019, 10:07 AM
It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here).  It also might be a WIP, given the comment in `join()`.  @yuja?

{sessionvars} (with no %template) would crash without this change.
Queued, thanks.

mharbison72 added a commit: rHG371765e775a2: webutil: add missing argument to join().Nov 24 2019, 10:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG371765e775a2: webutil: add missing argument to join() (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webutil.py (2 lines)

Diff 18388

mercurial/hgweb/webutil.py

} }
separator = b'&' separator = b'&'
def join(self, context, mapping, sep): def join(self, context, mapping, sep):
# could be '{separator}{name}={value|urlescape}' # could be '{separator}{name}={value|urlescape}'
raise error.ParseError(_(b'not displayable without template')) raise error.ParseError(_(b'not displayable without template'))
def show(self, context, mapping): def show(self, context, mapping):
return self.join(context, b'') return self.join(context, mapping, b'')
def tobool(self, context, mapping): def tobool(self, context, mapping):
return bool(self._vars) return bool(self._vars)
def tovalue(self, context, mapping): def tovalue(self, context, mapping):
return self._vars return self._vars