This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7557

annotate: describe --skip as taking a revset
ClosedPublic

Authored by durin42 on Dec 6 2019, 12:59 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa6483107a07a: annotate: describe --skip as taking a revset
Summary

It's obvious to me, but probably wouldn't be obvious to a novice user.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Dec 6 2019, 12:59 PM
pulkit added a subscriber: pulkit.Dec 6 2019, 1:10 PM

Isn't it that where ever we says revisions we imply revsets?

durin42 added a comment.Dec 6 2019, 1:12 PM

It said revision before, so at a minimum we should add an s...

(I don't know if we imply revset when we say revisions.)

pulkit accepted this revision.Dec 10 2019, 10:06 AM
This revision is now accepted and ready to land.Dec 10 2019, 10:06 AM
durin42 added a commit: rHGa6483107a07a: annotate: describe --skip as taking a revset.Dec 10 2019, 10:45 AM
Closed by commit rHGa6483107a07a: annotate: describe --skip as taking a revset (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)

Diff 18495

mercurial/commands.py

b'line-number', b'line-number',
None, None,
_(b'show line number at the first appearance'), _(b'show line number at the first appearance'),
), ),
( (
b'', b'',
b'skip', b'skip',
[], [],
_(b'revision to not display (EXPERIMENTAL)'), _(b'revset to not display (EXPERIMENTAL)'),
_(b'REV'), _(b'REV'),
), ),
] ]
+ diffwsopts + diffwsopts
+ walkopts + walkopts
+ formatteropts, + formatteropts,
_(b'[-r REV] [-f] [-a] [-u] [-d] [-n] [-c] [-l] FILE...'), _(b'[-r REV] [-f] [-a] [-u] [-d] [-n] [-c] [-l] FILE...'),
helpcategory=command.CATEGORY_FILE_CONTENTS, helpcategory=command.CATEGORY_FILE_CONTENTS,