This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7586

remotefilelog: have command wait for background task in the tests
ClosedPublic

Authored by marmoute on Dec 9 2019, 8:02 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG88ab1295db4c: remotefilelog: have command wait for background task in the tests
Summary

We leverage the feature introduced in the two previous commit to have the main
command wait for the background task to be finished before returning.

All test still pass and instability seems to have gone away.

Most of the sleep and explicit wait are now useless and will be cleaned up in
later changesets.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 9 2019, 8:02 AM

target is the stable-branch

durin42 accepted this revision.Dec 9 2019, 10:14 AM
This revision is now accepted and ready to land.Dec 9 2019, 10:14 AM
marmoute added a comment.Dec 11 2019, 5:26 AM

For those who wants to see the test misbehaving, your just need to run it in a loop on heavy load:
python run-tests.py --runs-per-test 10000 --loop -j 90 test-remotefilelog-bgprefetch.t

Revision Contents
Changeset List

Diff 18611

tests/test-remotefilelog-bgprefetch.t

#require no-windows #require no-windows
$ . "$TESTDIR/remotefilelog-library.sh" $ . "$TESTDIR/remotefilelog-library.sh"
# devel.remotefilelog.ensurestart: reduce race condition with # devel.remotefilelog.ensurestart: reduce race condition with
# waiton{repack/prefetch} # waiton{repack/prefetch}
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [devel] > [devel]
> remotefilelog.ensurestart=True > remotefilelog.ensurestart=True
> remotefilelog.bg-wait=True
> EOF > EOF
$ hg init master $ hg init master
$ cd master $ cd master
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [remotefilelog] > [remotefilelog]
> server=True > server=True
> EOF > EOF

tests/test-remotefilelog-repack-fast.t

#require no-windows #require no-windows
$ . "$TESTDIR/remotefilelog-library.sh" $ . "$TESTDIR/remotefilelog-library.sh"
# devel.remotefilelog.ensurestart: reduce race condition with # devel.remotefilelog.ensurestart: reduce race condition with
# waiton{repack/prefetch} # waiton{repack/prefetch}
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [remotefilelog] > [remotefilelog]
> fastdatapack=True > fastdatapack=True
> [devel] > [devel]
> remotefilelog.ensurestart=True > remotefilelog.ensurestart=True
> remotefilelog.bg-wait=True
> EOF > EOF
$ hg init master $ hg init master
$ cd master $ cd master
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [remotefilelog] > [remotefilelog]
> server=True > server=True
> serverexpiration=-1 > serverexpiration=-1

tests/test-remotefilelog-repack.t

#require no-windows #require no-windows
$ . "$TESTDIR/remotefilelog-library.sh" $ . "$TESTDIR/remotefilelog-library.sh"
# devel.remotefilelog.ensurestart: reduce race condition with # devel.remotefilelog.ensurestart: reduce race condition with
# waiton{repack/prefetch} # waiton{repack/prefetch}
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [devel] > [devel]
> remotefilelog.ensurestart=True > remotefilelog.ensurestart=True
> remotefilelog.bg-wait=True
> EOF > EOF
$ hg init master $ hg init master
$ cd master $ cd master
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [remotefilelog] > [remotefilelog]
> server=True > server=True
> serverexpiration=-1 > serverexpiration=-1