Page MenuHomePhabricator

remotefilelog: remove the `ensurestart` usage
ClosedPublic

Authored by marmoute on Dec 9 2019, 8:02 AM.

Details

Summary

The option does not seems to do what we want since it does not wait on the background
process actually starting (eg: taking the lock). And the race have been dealt
with another way anyway.

This effectively back out changeset 2c74337e6483.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 9 2019, 8:02 AM

target is the stable-branch

durin42 added a subscriber: durin42.Dec 9 2019, 9:56 AM

This doesn't apply to stable. I also checked default, and it doesn't apply there either.

Wait, I just saw the chain. Thanks for weird emails phabricator!

This is wrong, because now remotefilelog will do ensurestart=True (the default) which is a significant performance hit for remotefilelog users.

durin42 requested changes to this revision.Dec 9 2019, 10:13 AM
This revision now requires changes to proceed.Dec 9 2019, 10:13 AM

good spot. I'll update that last patch.

marmoute updated this revision to Diff 18557.Dec 9 2019, 10:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.