This is an archive of the discontinued Mercurial Phabricator instance.

match: normalize `cwd` early
ClosedPublic

Authored by martinvonz on Dec 13 2019, 2:50 PM.

Details

Summary

By having cwd in absolute form, we won't have to adjust it when
passing it to subrepo matchers. This will matter for a coming patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 13 2019, 2:50 PM
pulkit added a subscriber: pulkit.Dec 20 2019, 7:17 AM
pulkit added inline comments.
mercurial/match.py
232

util.normpath instead of os.path.normpath

martinvonz updated this revision to Diff 18894.Dec 20 2019, 9:52 AM
martinvonz marked an inline comment as done.Dec 20 2019, 9:52 AM
pulkit accepted this revision.Dec 20 2019, 11:33 AM
This revision is now accepted and ready to land.Dec 20 2019, 11:33 AM
This revision was automatically updated to reflect the committed changes.

(The doctest failures are from D7649. The ../$TESTTMP stuff is this one.)