This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7673

util: rename a variable to avoid confusing pytype
ClosedPublic

Authored by mharbison72 on Dec 15 2019, 11:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGeff050dbb703: util: rename a variable to avoid confusing pytype
Summary

Fixes the following warning:

line 1205, in f: No attribute 'append' on Dict[nothing, nothing] [attribute-error]
      In Union[Dict[nothing, nothing], list]

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (8 lines)

Diff 18737

mercurial/util.py

if n == 4: if n == 4:
return (vints[0], vints[1], vints[2], extra) return (vints[0], vints[1], vints[2], extra)
def cachefunc(func): def cachefunc(func):
'''cache the result of function calls''' '''cache the result of function calls'''
# XXX doesn't handle keywords args # XXX doesn't handle keywords args
if func.__code__.co_argcount == 0: if func.__code__.co_argcount == 0:
cache = [] listcache = []
def f(): def f():
if len(cache) == 0: if len(listcache) == 0:
cache.append(func()) listcache.append(func())
return cache[0] return listcache[0]
return f return f
cache = {} cache = {}
if func.__code__.co_argcount == 1: if func.__code__.co_argcount == 1:
# we gain a small amount of time because # we gain a small amount of time because
# we don't need to pack/unpack the list # we don't need to pack/unpack the list
def f(arg): def f(arg):
if arg not in cache: if arg not in cache: