This is an archive of the discontinued Mercurial Phabricator instance.

typing: add an assertion to util.versiontuple
ClosedPublic

Authored by mharbison72 on Dec 15 2019, 11:12 PM.

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

Summary

Fixes the following warning:

line 1177, in versiontuple: No attribute 'split' on None [attribute-error]
     In Optional[bytes]

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

This revision is now accepted and ready to land.Dec 16 2019, 12:55 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			mercurial/util.py (2 lines)

Commit	Parents	Author	Summary	Date
c271f1425d34	c255fd44ba7d	Matt Harbison		Dec 15 2019, 9:36 PM

Status	Author	Revision
Closed	mharbison72	D7677 typing: suppress a warning that mercurial.windows.checkosfilename is missing
Closed	mharbison72	D7676 typing: add an assertion to util.versiontuple
Closed	mharbison72	D7675 util: move common proxyobserver attributes to the base class
Closed	mharbison72	D7674 typing: add a couple of assertions to lrucachedict to help pytype
Closed	mharbison72	D7673 util: rename a variable to avoid confusing pytype
Closed	mharbison72	D7672 pytype: suppress the import-error in util.py when importing re2
Closed	mharbison72	D7671 debugcommands: finish moving `extendeddateformats` from util to dateutil
Closed	mharbison72	D7670 ui: convert exception data to bytes when printing chained exception info
Closed	mharbison72	D7669 ui: use a context manager to handle file streams in edit()

	m = remod.match(br'(\d+(?:\.\d+){,2})[\+-]?(.*)', v)			m = remod.match(br'(\d+(?:\.\d+){,2})[\+-]?(.*)', v)
	if not m:			if not m:
	vparts, extra = b'', v			vparts, extra = b'', v
	elif m.group(2):			elif m.group(2):
	vparts, extra = m.groups()			vparts, extra = m.groups()
	else:			else:
	vparts, extra = m.group(1), None			vparts, extra = m.group(1), None

				assert vparts is not None # help pytype

	vints = []			vints = []
	for i in vparts.split(b'.'):			for i in vparts.split(b'.'):
	try:			try:
	vints.append(int(i))			vints.append(int(i))
	except ValueError:			except ValueError:
	break			break
	# (3, 6) -> (3, 6, None)			# (3, 6) -> (3, 6, None)
	while len(vints) < 3:			while len(vints) < 3: