This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7706

tests-pure: fixing test-parseindex2
AbandonedPublic

Authored by gracinet on Dec 20 2019, 11:24 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This is a followup to D7603 (49fa0b31ee1d) which broke
the tests for pure Python implementation. There are two
divergences between pure and C implementations:

  • the pure implementation would accept only -1 as slice end, whereas C accepts both -1 and len(index)
  • in pure Python, headrevs is provided by revlog.py, not by the index.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex2.py (6 lines)

Diff 18898

tests/test-parseindex2.py

node = hexrev(p1) + hexrev(p2) + b'.' * 12 node = hexrev(p1) + hexrev(p2) + b'.' * 12
index.append((0, 0, 12, 1, 34, p1, p2, node)) index.append((0, 0, 12, 1, 34, p1, p2, node))
appendrev(4) appendrev(4)
appendrev(5) appendrev(5)
appendrev(6) appendrev(6)
self.assertEqual(len(index), 7) self.assertEqual(len(index), 7)
del index[1:7] del index[1:-1]
# assertions that failed before correction # assertions that failed before correction
self.assertEqual(len(index), 1) # was 4 self.assertEqual(len(index), 1) # was 4
headrevs = getattr(index, 'headrevs', None)
if headrevs is not None: # not implemented in pure
self.assertEqual(index.headrevs(), [0]) # gave ValueError self.assertEqual(index.headrevs(), [0]) # gave ValueError
if __name__ == '__main__': if __name__ == '__main__':
import silenttestrunner import silenttestrunner
silenttestrunner.main(__name__) silenttestrunner.main(__name__)