This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7709

verify: update comment to say that lfs doesn't need fulltext to check renames
ClosedPublic

Authored by mharbison72 on Dec 23 2019, 2:47 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGa447efd991b9: verify: update comment to say that lfs doesn't need fulltext to check renames
Summary

The reason is that filelog.renamed() indirectly calls filelog.revision(),
which is what accesses the full text. However, LFS wraps filelog.renamed()
and completely handles the case where an LFS blob is in play by using rawdata.

I've got a test to demonstrate that this is the case, and prevent regressions.
But the skipread flag is set on all lfs revisions when using --no-lfs,
regardless of whether or not the blobs are local. Just above this, that flag is
consulted, causing the rename checks to be skipped. That will need to be
loosened up first.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/verify.py (5 lines)

Diff 18915

mercurial/verify.py

else: else:
del filenodes[f][n] del filenodes[f][n]
if n in state[b'skipread']: if n in state[b'skipread']:
continue continue
# check renames # check renames
try: try:
# This requires resolving fulltext (at least on revlogs). We # This requires resolving fulltext (at least on revlogs,
# may want ``verifyintegrity()`` to pass a set of nodes with # though not with LFS revisions). We may want
# ``verifyintegrity()`` to pass a set of nodes with
# rename metadata as an optimization. # rename metadata as an optimization.
rp = fl.renamed(n) rp = fl.renamed(n)
if rp: if rp:
if lr is not None and ui.verbose: if lr is not None and ui.verbose:
ctx = lrugetctx(lr) ctx = lrugetctx(lr)
if not any(rp[0] in pctx for pctx in ctx.parents()): if not any(rp[0] in pctx for pctx in ctx.parents()):
self._warn( self._warn(
_( _(