This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7749

shelve: drop an unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 5:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG414cb20e241e: shelve: drop an unused variable assignment
Summary

Caught by PyCharm. This stopped being used in a3b285882724.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 5:08 PM
pulkit accepted this revision.Dec 30 2019, 7:44 AM
This revision is now accepted and ready to land.Dec 30 2019, 7:44 AM
mharbison72 added a commit: rHG414cb20e241e: shelve: drop an unused variable assignment.Dec 30 2019, 8:31 AM
Closed by commit rHG414cb20e241e: shelve: drop an unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (2 lines)

Diff 19009

mercurial/shelve.py

return 1 return 1
# Create a matcher so that prefetch doesn't attempt to fetch # Create a matcher so that prefetch doesn't attempt to fetch
# the entire repository pointlessly, and as an optimisation # the entire repository pointlessly, and as an optimisation
# for movedirstate, if needed. # for movedirstate, if needed.
match = scmutil.matchfiles(repo, repo[node].files()) match = scmutil.matchfiles(repo, repo[node].files())
_shelvecreatedcommit(repo, node, name, match) _shelvecreatedcommit(repo, node, name, match)
if ui.formatted():
desc = stringutil.ellipsis(desc, ui.termwidth())
ui.status(_(b'shelved as %s\n') % name) ui.status(_(b'shelved as %s\n') % name)
if opts[b'keep']: if opts[b'keep']:
with repo.dirstate.parentchange(): with repo.dirstate.parentchange():
scmutil.movedirstate(repo, parent, match) scmutil.movedirstate(repo, parent, match)
else: else:
hg.update(repo, parent.node()) hg.update(repo, parent.node())
if origbranch != repo[b'.'].branch() and not _isbareshelve(pats, opts): if origbranch != repo[b'.'].branch() and not _isbareshelve(pats, opts):
repo.dirstate.setbranch(origbranch) repo.dirstate.setbranch(origbranch)