This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7750

run-tests: ensure the script exits when it fails to change directories
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 5:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbd3fa45c0662: run-tests: ensure the script exits when it fails to change directories
Summary

Caught by PyCharm as an unused variable assignment. This regressed in
c496e8c14b9e.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 5:08 PM
pulkit accepted this revision.Dec 30 2019, 7:44 AM
This revision is now accepted and ready to land.Dec 30 2019, 7:44 AM

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 19010

tests/run-tests.py

after.setdefault(pos, []).append(l) after.setdefault(pos, []).append(l)
prepos = pos prepos = pos
pos = n pos = n
addsalt(n, False) addsalt(n, False)
rawcmd = l[4:] rawcmd = l[4:]
cmd = rawcmd.split() cmd = rawcmd.split()
toggletrace(rawcmd) toggletrace(rawcmd)
if len(cmd) == 2 and cmd[0] == b'cd': if len(cmd) == 2 and cmd[0] == b'cd':
l = b' $ cd %s || exit 1\n' % cmd[1] rawcmd = b'cd %s || exit 1\n' % cmd[1]
script.append(rawcmd) script.append(rawcmd)
elif l.startswith(b' > '): # continuations elif l.startswith(b' > '): # continuations
after.setdefault(prepos, []).append(l) after.setdefault(prepos, []).append(l)
script.append(l[4:]) script.append(l[4:])
elif l.startswith(b' '): # results elif l.startswith(b' '): # results
# Queue up a list of expected results. # Queue up a list of expected results.
expected.setdefault(pos, []).append(l[2:]) expected.setdefault(pos, []).append(l[2:])
else: else: