This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	mharbison72	D7761 hgweb: delete a local variable instead of setting to `None`
Closed	mharbison72	D7760 tests: drop unused local variable assignments in linelog
Closed	mharbison72	D7759 ui: delete local variables instead of setting to `None`
Closed	mharbison72	D7758 tests: drop unused local variable assignments in remotefilelog
Closed	mharbison72	D7757 fastannotate: drop unused local variable assignments
Closed	mharbison72	D7756 fsmonitor: drop an unused local variable assignment
Closed	mharbison72	D7755 mq: drop an unused variable assignment
Closed	mharbison72	D7754 hgweb: delete local variable instead of setting it to `None`
Closed	mharbison72	D7753 annotate: avoid using a list comprehension to fill a list with fixed values
Closed	mharbison72	D7752 fsmonitor: drop an unused local variable
Closed	mharbison72	D7751 absorb: avoid using a list comprehension to fill a list with fixed values

Diff 19021


	def start_response(status, response_headers, exc_info=None):			def start_response(status, response_headers, exc_info=None):
	if exc_info:			if exc_info:
	try:			try:
	if headers_sent:			if headers_sent:
	# Re-raise original exception if headers sent			# Re-raise original exception if headers sent
	raise exc_info[0](exc_info[1], exc_info[2])			raise exc_info[0](exc_info[1], exc_info[2])
	finally:			finally:
	exc_info = None # avoid dangling circular ref			del exc_info # avoid dangling circular ref
	elif headers_set:			elif headers_set:
	raise AssertionError(b"Headers already set!")			raise AssertionError(b"Headers already set!")

	headers_set[:] = [status, response_headers]			headers_set[:] = [status, response_headers]
	return write			return write

	content = application(environ, start_response)			content = application(environ, start_response)
	try:			try:
	for chunk in content:			for chunk in content:
	write(chunk)			write(chunk)
	if not headers_sent:			if not headers_sent:
	write(b'') # send headers now if body was empty			write(b'') # send headers now if body was empty
	finally:			finally:
	getattr(content, 'close', lambda: None)()			getattr(content, 'close', lambda: None)()