This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7759

ui: delete local variables instead of setting to `None`
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 8:29 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe3ce3731d621: ui: delete local variables instead of setting to `None`
Summary

The previous code was flagged by PyCharm as an unused variable assignment.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (5 lines)

Diff 19019

mercurial/ui.py

curframe = inspect.currentframe() curframe = inspect.currentframe()
calframe = inspect.getouterframes(curframe, 2) calframe = inspect.getouterframes(curframe, 2)
fname, lineno, fmsg = calframe[stacklevel][1:4] fname, lineno, fmsg = calframe[stacklevel][1:4]
fname, fmsg = pycompat.sysbytes(fname), pycompat.sysbytes(fmsg) fname, fmsg = pycompat.sysbytes(fname), pycompat.sysbytes(fmsg)
self.write_err(b'%s at: %s:%d (%s)\n' % (msg, fname, lineno, fmsg)) self.write_err(b'%s at: %s:%d (%s)\n' % (msg, fname, lineno, fmsg))
self.log( self.log(
b'develwarn', b'%s at: %s:%d (%s)\n', msg, fname, lineno, fmsg b'develwarn', b'%s at: %s:%d (%s)\n', msg, fname, lineno, fmsg
) )
curframe = calframe = None # avoid cycles
# avoid cycles
del curframe
del calframe
def deprecwarn(self, msg, version, stacklevel=2): def deprecwarn(self, msg, version, stacklevel=2):
"""issue a deprecation warning """issue a deprecation warning
- msg: message explaining what is deprecated and how to upgrade, - msg: message explaining what is deprecated and how to upgrade,
- version: last version where the API will be supported, - version: last version where the API will be supported,
""" """
if not ( if not (