This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7762

histedit: avoid using a list comprehension to fill a list with fixed values
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 10:04 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG801b8d314791: histedit: avoid using a list comprehension to fill a list with fixed values
Summary

Flagged by PyCharm as an unused assignment for the variable in the list.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 19022

hgext/histedit.py

actions = [] actions = []
def addverb(v): def addverb(v):
a = actiontable[v] a = actiontable[v]
lines = a.message.split(b"\n") lines = a.message.split(b"\n")
if len(a.verbs): if len(a.verbs):
v = b', '.join(sorted(a.verbs, key=lambda v: len(v))) v = b', '.join(sorted(a.verbs, key=lambda v: len(v)))
actions.append(b" %s = %s" % (v, lines[0])) actions.append(b" %s = %s" % (v, lines[0]))
actions.extend([b' %s' for l in lines[1:]]) actions.extend([b' %s'] * (len(lines) - 1))
for v in ( for v in (
sorted(primaryactions) sorted(primaryactions)
+ sorted(secondaryactions) + sorted(secondaryactions)
+ sorted(tertiaryactions) + sorted(tertiaryactions)
): ):
addverb(v) addverb(v)
actions.append(b'') actions.append(b'')