( )⚙ D7764 revset: drop some unused code in the `remote` revset

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7764

revset: drop some unused code in the `remote` revset
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 10:04 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6e8678e7223a: revset: drop some unused code in the `remote` revset
Summary

PyCharm flagged the revs = [..] as an unused assignment. But then neither
revs nor checkout is used, and I can't see where hg.addbranchrevs() has
external side effects.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 10:04 PM
pulkit accepted this revision.Dec 30 2019, 8:11 AM
This revision is now accepted and ready to land.Dec 30 2019, 8:11 AM
mharbison72 added a commit: rHG6e8678e7223a: revset: drop some unused code in the `remote` revset.Dec 30 2019, 8:33 AM
Closed by commit rHG6e8678e7223a: revset: drop some unused code in the `remote` revset (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (4 lines)

Diff 19025

mercurial/revset.py

q = repo[b'.'].branch() q = repo[b'.'].branch()
dest = b'' dest = b''
if len(l) > 1: if len(l) > 1:
# i18n: "remote" is a keyword # i18n: "remote" is a keyword
dest = getstring(l[1], _(b"remote requires a repository path")) dest = getstring(l[1], _(b"remote requires a repository path"))
dest = repo.ui.expandpath(dest or b'default') dest = repo.ui.expandpath(dest or b'default')
dest, branches = hg.parseurl(dest) dest, branches = hg.parseurl(dest)
revs, checkout = hg.addbranchrevs(repo, repo, branches, [])
if revs:
revs = [repo.lookup(rev) for rev in revs]
other = hg.peer(repo, {}, dest) other = hg.peer(repo, {}, dest)
n = other.lookup(q) n = other.lookup(q)
if n in repo: if n in repo:
r = repo[n].rev() r = repo[n].rev()
if r in subset: if r in subset:
return baseset([r]) return baseset([r])
return baseset() return baseset()