This is an archive of the discontinued Mercurial Phabricator instance.

ui: refactor `readconfig()` into a form that can consume resources

Authored by mharbison72 on Dec 30 2019, 12:43 AM.



The old form can't completely go away, because files outside of packages still
need to be read. The name passed in here is a tuple of package name, resource
as needed by the resource API.

I like the idea of stating the config file is embedded in the executable by
listing is as exe!package.resource. This would be consistent with how
debuginstall points to the executable for the python executable, lib, and
installed modules. While in practice the filesystem path is available from the
backing ResourceReader when the resource is opened, it is a relative path on py2
and absolute on py3. Further, while this would show in the hg config output
for each option if set as such here, it doesn't show in the reading from...
line when --debug is used. The file isn't actually open where that prints, so
there's no way I see to get that info there. So I opted for the simple prefix
to distinguish resources from files.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 30 2019, 12:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.