This is an archive of the discontinued Mercurial Phabricator instance.

codemod: simplify nested withs
ClosedPublic

Authored by quark on Jul 13 2017, 9:35 PM.
Tags
  • Restricted Project

Details

Summary

This is the result of running:

python contrib/codemod/codemod_nestedwith.py **/*.py

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Jul 13 2017, 9:35 PM
quark added a comment.Jul 13 2017, 9:37 PM

Suggestion: use "Whitespace Changes: Ignore All" to view the diff: https://phab.mercurial-scm.org/D77?vs=on&id=121&whitespace=ignore-all#toc

quark added a project: Restricted Project.
durin42 accepted this revision.Jul 14 2017, 11:50 AM
durin42 added a subscriber: durin42.

Queued.

Not sure if it's worth hanging on to the script to perform the edits. Thoughts?

This revision is now accepted and ready to land.Jul 14 2017, 11:50 AM
martinvonz edited edge metadata.Jul 14 2017, 11:52 AM
In D77#1069, @durin42 wrote:

Queued.
Not sure if it's worth hanging on to the script to perform the edits. Thoughts?

Yes, that's what I felt too (that it's not worth it). It seems unlikely we'll run it again and it will just be deleted in 5 years or something. I appreciate Jun sharing it, though.

Maybe put the script in commit message then? I ran it on fb-hgext so I guess other extension developers might want to run it on their repos too.

In D77#1095, @quark wrote:

Maybe put the script in commit message then? I ran it on fb-hgext so I guess other extension developers might want to run it on their repos too.

Sounds good. Will do.

This revision was automatically updated to reflect the committed changes.