This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7830

revlog: reorder a conditionnal about revlogio
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:02 PM.

Details

Reviewers
indygreg
pulkit
Group Reviewers
hg-reviewers
Commits
rHG612225e994ff: revlog: reorder a conditionnal about revlogio
Summary

if we are using REVLOGV0, we will not use a rust based index. This small line
movement make it clearer.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 11 2020, 12:02 PM
pulkit accepted this revision.Jan 13 2020, 7:33 AM
This revision is now accepted and ready to land.Jan 13 2020, 7:33 AM
marmoute added a commit: rHG612225e994ff: revlog: reorder a conditionnal about revlogio.Jan 13 2020, 9:19 AM
Closed by commit rHG612225e994ff: revlog: reorder a conditionnal about revlogio (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute updated this revision to Diff 19168.Jan 13 2020, 10:05 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (4 lines)

Diff 19165

mercurial/revlog.py

) )
# sparse-revlog can't be on without general-delta (issue6056) # sparse-revlog can't be on without general-delta (issue6056)
if not self._generaldelta: if not self._generaldelta:
self._sparserevlog = False self._sparserevlog = False
self._storedeltachains = True self._storedeltachains = True
self._io = revlogio() self._io = revlogio()
if rustrevlog is not None and self.opener.options.get(b'rust.index'):
self._io = rustrevlogio()
if self.version == REVLOGV0: if self.version == REVLOGV0:
self._io = revlogoldio() self._io = revlogoldio()
elif rustrevlog is not None and self.opener.options.get(b'rust.index'):
self._io = rustrevlogio()
try: try:
d = self._io.parseindex(indexdata, self._inline) d = self._io.parseindex(indexdata, self._inline)
except (ValueError, IndexError): except (ValueError, IndexError):
raise error.RevlogError( raise error.RevlogError(
_(b"index %s is corrupted") % self.indexfile _(b"index %s is corrupted") % self.indexfile
) )
self.index, self._chunkcache = d self.index, self._chunkcache = d
if not self._chunkcache: if not self._chunkcache: