This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7831

changelog: fix the diverted opener to accept more kwargs
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:02 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7f67f53492f7: changelog: fix the diverted opener to accept more kwargs
Summary

The current code prevent the use of atomictemp file with the changelog
opener. I do not see a good reason for this limitation.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 11 2020, 12:02 PM
pulkit accepted this revision.Jan 13 2020, 7:36 AM
This revision is now accepted and ready to land.Jan 13 2020, 7:36 AM
marmoute updated this revision to Diff 19169.Jan 13 2020, 10:05 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (11 lines)

Diff 19166

mercurial/changelog.py

def __exit__(self, *args): def __exit__(self, *args):
return self.fp.__exit__(*args) return self.fp.__exit__(*args)
def _divertopener(opener, target): def _divertopener(opener, target):
"""build an opener that writes in 'target.a' instead of 'target'""" """build an opener that writes in 'target.a' instead of 'target'"""
def _divert(name, mode=b'r', checkambig=False): def _divert(name, mode=b'r', checkambig=False, **kwargs):
if name != target: if name != target:
return opener(name, mode) return opener(name, mode, **kwargs)
return opener(name + b".a", mode) return opener(name + b".a", mode, **kwargs)
return _divert return _divert
def _delayopener(opener, target, buf): def _delayopener(opener, target, buf):
"""build an opener that stores chunks in 'buf' instead of 'target'""" """build an opener that stores chunks in 'buf' instead of 'target'"""
def _delay(name, mode=b'r', checkambig=False): def _delay(name, mode=b'r', checkambig=False, **kwargs):
if name != target: if name != target:
return opener(name, mode) return opener(name, mode, **kwargs)
assert not kwargs
return appender(opener, name, mode, buf) return appender(opener, name, mode, buf)
return _delay return _delay
@attr.s @attr.s
class _changelogrevision(object): class _changelogrevision(object):
# Extensions might modify _defaultextra, so let the constructor below pass # Extensions might modify _defaultextra, so let the constructor below pass