This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7832

transaction: add a `hasfinalize` method
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:02 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8e09551206f5: transaction: add a `hasfinalize` method
Summary

The method allow code to check if an existing callback exists. It allow them to
skip potentially expensive setup for a callback.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 11 2020, 12:02 PM
pulkit accepted this revision.Jan 13 2020, 7:36 AM
This revision is now accepted and ready to land.Jan 13 2020, 7:36 AM
marmoute added a commit: rHG8e09551206f5: transaction: add a `hasfinalize` method.Jan 13 2020, 9:19 AM
Closed by commit rHG8e09551206f5: transaction: add a `hasfinalize` method (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute updated this revision to Diff 19170.Jan 13 2020, 10:05 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (6 lines)

Diff 19167

mercurial/transaction.py

for cat in categories: for cat in categories:
# remove callback since the data will have been flushed # remove callback since the data will have been flushed
any = self._pendingcallback.pop(cat)(self) any = self._pendingcallback.pop(cat)(self)
self._anypending = self._anypending or any self._anypending = self._anypending or any
self._anypending |= self._generatefiles(suffix=b'.pending') self._anypending |= self._generatefiles(suffix=b'.pending')
return self._anypending return self._anypending
@active @active
def hasfinalize(self, category):
"""check is a callback already exist for a category
"""
return category in self._finalizecallback
@active
def addfinalize(self, category, callback): def addfinalize(self, category, callback):
"""add a callback to be called when the transaction is closed """add a callback to be called when the transaction is closed
The transaction will be given as callback's first argument. The transaction will be given as callback's first argument.
Category is a unique identifier to allow overwriting old callbacks with Category is a unique identifier to allow overwriting old callbacks with
newer callbacks. newer callbacks.
""" """