Page MenuHomePhabricator

graftcopies: use _filter() for filtering out invalid copies
ClosedPublic

Authored by martinvonz on Jan 14 2020, 12:06 PM.

Details

Summary

graftcopies() (formerly called duplicatecopies()) checked that the
copy destination existed in the working copy, but it didn't check that
copy source existed in the parent of the working copy. In
test-graft.t we can see that as warnings about not finding ancestors
of the copied files, and also empty commits getting created.

This patch uses the existing _filter() function for filtering out
invalid copies. In addition to the aforementioned types, that also
includes copies where source and destination is the same.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.