Page MenuHomePhabricator

graftcopies: document why the function is useful at all
ClosedPublic

Authored by martinvonz on Jan 14 2020, 12:06 PM.

Details

Summary

Despite having spent a significant amount on time on the copy-tracing
code, I thought graftcopies() (formerly known as
duplicatecopies()) was needed to duplicate copies after calling
merge.update() to do a merge (as merge.graft() does), but it's
actually usually not needed; merge.update() takes care of most
copies. This patch documents what the function is for.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 14 2020, 12:06 PM
pulkit accepted this revision.Jan 16 2020, 10:39 AM
This revision is now accepted and ready to land.Jan 16 2020, 10:39 AM