Page MenuHomePhabricator

phabricator: post revisions in ascending topological order (issue6241)

Authored by mharbison72 on Jan 14 2020, 4:39 PM.



The parent in phabricator ends up being the last revision posted, so sorting the
user input into ascending order should be enough to preserve the proper

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 14 2020, 4:39 PM

I don't see any guardrails that prevent mixing unrelated local stuff into the revset and erroneously assigning the last revision processed as a parent, but that's less trivial and can probably wait until someone stumbles on it.

pulkit accepted this revision.Jan 14 2020, 4:46 PM
This revision is now accepted and ready to land.Jan 14 2020, 4:46 PM