This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7880

lfs: rename a variable to clarify its use
ClosedPublic

Authored by mharbison72 on Jan 14 2020, 11:09 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG84f2becbd106: lfs: rename a variable to clarify its use
Summary

This is the response object, not a request.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Jan 14 2020, 11:09 PM
pulkit accepted this revision.Jan 15 2020, 7:11 AM
This revision is now accepted and ready to land.Jan 15 2020, 7:11 AM
mharbison72 added a commit: rHG84f2becbd106: lfs: rename a variable to clarify its use.Jan 15 2020, 8:17 AM
Closed by commit rHG84f2becbd106: lfs: rename a variable to clarify its use (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/lfs/blobstore.py (10 lines)

Diff 19279

hgext/lfs/blobstore.py

request.add_header('Content-Type', 'application/octet-stream') request.add_header('Content-Type', 'application/octet-stream')
request.add_header('Content-Length', len(request.data)) request.add_header('Content-Length', len(request.data))
for k, v in headers: for k, v in headers:
request.add_header(pycompat.strurl(k), pycompat.strurl(v)) request.add_header(pycompat.strurl(k), pycompat.strurl(v))
response = b'' response = b''
try: try:
with contextlib.closing(self.urlopener.open(request)) as req: with contextlib.closing(self.urlopener.open(request)) as res:
ui = self.ui # Shorten debug lines ui = self.ui # Shorten debug lines
if self.ui.debugflag: if self.ui.debugflag:
ui.debug(b'Status: %d\n' % req.status) ui.debug(b'Status: %d\n' % res.status)
# lfs-test-server and hg serve return headers in different # lfs-test-server and hg serve return headers in different
# order # order
headers = pycompat.bytestr(req.info()).strip() headers = pycompat.bytestr(res.info()).strip()
ui.debug(b'%s\n' % b'\n'.join(sorted(headers.splitlines()))) ui.debug(b'%s\n' % b'\n'.join(sorted(headers.splitlines())))
if action == b'download': if action == b'download':
# If downloading blobs, store downloaded data to local # If downloading blobs, store downloaded data to local
# blobstore # blobstore
localstore.download(oid, req) localstore.download(oid, res)
else: else:
while True: while True:
data = req.read(1048576) data = res.read(1048576)
if not data: if not data:
break break
response += data response += data
if response: if response:
ui.debug(b'lfs %s response: %s' % (action, response)) ui.debug(b'lfs %s response: %s' % (action, response))
except util.urlerr.httperror as ex: except util.urlerr.httperror as ex:
if self.ui.debugflag: if self.ui.debugflag:
self.ui.debug( self.ui.debug(