This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7949

py3: suppress unraisable exceptions in test-worker.t
ClosedPublic

Authored by indygreg on Jan 18 2020, 4:18 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb5aaa09be18c: py3: suppress unraisable exceptions in test-worker.t
Summary

Python 3.8 calls sys.unraisablehook when an unraisable
exception is encountered. The default behavior is to print a
warning.

test-worker.t was triggering this hook due to a race between
a newly forked process exiting and that process's
_os.register_at_fork handlers running. I was seeing the
stdlib's random module in the stack re-seeding itself. Although
there could be other after-fork handlers in the mix.

This commit defines sys.unraisablehook to effectively no-op.
This suppresses the warning and makes test output on Python 3.8
consistent with prior versions. test-worker.t now passes on
Python 3.8.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Jan 18 2020, 4:18 PM
pulkit accepted this revision.Jan 21 2020, 11:02 AM
This revision is now accepted and ready to land.Jan 21 2020, 11:02 AM
indygreg added a commit: rHGb5aaa09be18c: py3: suppress unraisable exceptions in test-worker.t.Jan 21 2020, 11:25 AM
Closed by commit rHGb5aaa09be18c: py3: suppress unraisable exceptions in test-worker.t (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-worker.t (4 lines)

Diff 19453

tests/test-worker.t

Test UI worker interaction Test UI worker interaction
$ cat > t.py <<EOF $ cat > t.py <<EOF
> from __future__ import absolute_import, print_function > from __future__ import absolute_import, print_function
> import sys
> import time > import time
> from mercurial import ( > from mercurial import (
> error, > error,
> registrar, > registrar,
> ui as uimod, > ui as uimod,
> worker, > worker,
> ) > )
> sys.unraisablehook = lambda x: None
> def abort(ui, args): > def abort(ui, args):
> if args[0] == 0: > if args[0] == 0:
> # by first worker for test stability > # by first worker for test stability
> raise error.Abort(b'known exception') > raise error.Abort(b'known exception')
> return runme(ui, []) > return runme(ui, [])
> def exc(ui, args): > def exc(ui, args):
> if args[0] == 0: > if args[0] == 0:
> # by first worker for test stability > # by first worker for test stability
Exception: unknown exception Exception: unknown exception
Workers should not do cleanups in all cases Workers should not do cleanups in all cases
$ cat > $TESTTMP/detectcleanup.py <<EOF $ cat > $TESTTMP/detectcleanup.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import
> import atexit > import atexit
> import os > import os
> import sys
> import time > import time
> sys.unraisablehook = lambda x: None
> oldfork = os.fork > oldfork = os.fork
> count = 0 > count = 0
> parentpid = os.getpid() > parentpid = os.getpid()
> def delayedfork(): > def delayedfork():
> global count > global count
> count += 1 > count += 1
> pid = oldfork() > pid = oldfork()
> # make it easier to test SIGTERM hitting other workers when they have > # make it easier to test SIGTERM hitting other workers when they have