Page MenuHomePhabricator

cext: change two more vars to Py_ssize_t in manifest.c
ClosedPublic

Authored by spectral on Jan 21 2020, 3:25 PM.

Details

Summary

D7913 fixed a compiler warning with a signedness conflict in a ternary operator
by changing the types of some variables to be Py_ssize_t instead of size_t or
int. That commit missed these two cases since they aren't warned about (at least
on my compiler).

Both of these variables are produced by operations on variables that are
themselves Py_ssize_t now/already, so they should keep the same type.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 21 2020, 3:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

This should go to stable branch right?
cc: @martinvonz @durin42

Yes, I'll move this to stable.