Page MenuHomePhabricator

packaging: add configparser to inno requirements file
ClosedPublic

Authored by indygreg on Jan 22 2020, 11:03 PM.

Details

Summary

This dependency is missing and pip complains about it in
strict hashing mode. How this was missed, I have no clue.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Jan 22 2020, 11:03 PM
pulkit accepted this revision.Jan 23 2020, 7:12 AM
This revision is now accepted and ready to land.Jan 23 2020, 7:12 AM
This revision was automatically updated to reflect the committed changes.

This is needed on stable to be able to build the Inno installer there.

Yeah, it was flagged as stable in the branch metadata. But whoever queued it didn't see that. (Perhaps we should improve hg phabread to warn on branch name mismatch?)

I'll manually queue this for stable.

Yeah, it was flagged as stable in the branch metadata. But whoever queued it didn't see that. (Perhaps we should improve hg phabread to warn on branch name mismatch?)
I'll manually queue this for stable.

I'd be interested in something like this. But we've got more than default and stable at work, so it might need to be on the import side? The --exact parameter won't generally work because e.g. the amend entry in extras doesn't get carried in the patch, so that would fail to apply entirely. So it would need to be something like --exact-parent, which probably isn't as useful for Mercurial reviewers. Coupled with --bypass, you don't really need to be on the correct branch, I don't think. But it all seems like a related problem.