Page MenuHomePhabricator

wix: always normalize version string
ClosedPublic

Authored by indygreg on Fri, Jan 24, 11:34 PM.

Details

Summary

Before, it was possible to pass in a custom version string
which would not be valid in MSI. So we always normalize the
version string.

While we're here, also print when we normalize the version string,
for better visibility.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Fri, Jan 24, 11:34 PM
pulkit accepted this revision.Sat, Jan 25, 6:15 PM
This revision is now accepted and ready to land.Sat, Jan 25, 6:15 PM
This revision was automatically updated to reflect the committed changes.