This is an archive of the discontinued Mercurial Phabricator instance.

wix: use original version string for MSI filename
ClosedPublic

Authored by indygreg on Jan 24 2020, 11:34 PM.

Details

Summary

Version string normalization is mostly to placate MSI requirements.
I think it makes sense to use the original version string in
filenames.

Since we can have distinct versions normalizing to the same MSI
version string, this will allow us to distinguish between different
actual version strings based on the filename.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 24 2020, 11:34 PM
pulkit accepted this revision.Jan 25 2020, 6:16 PM
This revision is now accepted and ready to land.Jan 25 2020, 6:16 PM
This revision was automatically updated to reflect the committed changes.