This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D8032 copy: rename `wctx` to `ctx` since it will not necessarily be working copy
Closed	martinvonz	D8035 copy: add experimental support for marking committed copies
Abandoned	martinvonz	D8034 check-code: allow `hg cp -r`, by using a negative lookbehind
Closed	martinvonz	D8033 copy: move argument validation a little earlier
Closed	martinvonz	D8030 copy: add experimetal support for unmarking committed copies
Closed	martinvonz	D8029 copy: add option to unmark file as copied
Closed	martinvonz	D8031 copy: rewrite walkpat() to depend less on dirstate

Diff 19667

	(r'\butil\.Abort\b', "directly use error.Abort"),			(r'\butil\.Abort\b', "directly use error.Abort"),
	(r'\\|&', "don't use \|&, use 2>&1"),			(r'\\|&', "don't use \|&, use 2>&1"),
	(r'\w = +\w', "only one space after = allowed"),			(r'\w = +\w', "only one space after = allowed"),
	(			(
	r'\bsed\b.*[^\\]\\n',			r'\bsed\b.*[^\\]\\n',
	"don't use 'sed ... \\n', use a \\ and a newline",			"don't use 'sed ... \\n', use a \\ and a newline",
	),			),
	(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),			(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
	(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),			(r'(?<!hg )cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
	(r'grep.* -[ABC]', "don't use grep's context flags"),			(r'grep.* -[ABC]', "don't use grep's context flags"),
	(			(
	r'find.*-printf',			r'find.*-printf',
	"don't use 'find -printf', it doesn't exist on BSD find(1)",			"don't use 'find -printf', it doesn't exist on BSD find(1)",
	),			),
	(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),			(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
	],			],
	# warnings			# warnings

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19667			Jan 28 2020, 6:51 PM	★	★