This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8060

packaging: set the FileVersion field in the Inno installer executable
ClosedPublic

Authored by mharbison72 on Feb 1 2020, 1:48 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf37971c31067: packaging: set the FileVersion field in the Inno installer executable
Summary

Previously, Properties > Details > File version showed "0.0.0.0". This appears
to be a longstanding issue, and not part of the refactoring this cycle.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 19820

contrib/packaging/hgpackaging/inno.py

import jinja2 import jinja2
from .py2exe import ( from .py2exe import (
build_py2exe, build_py2exe,
stage_install, stage_install,
) )
from .util import ( from .util import (
find_vc_runtime_files, find_vc_runtime_files,
normalize_windows_version,
read_version_py, read_version_py,
) )
EXTRA_PACKAGES = { EXTRA_PACKAGES = {
'dulwich', 'dulwich',
'keyring', 'keyring',
'pygments', 'pygments',
'win32ctypes', 'win32ctypes',
if vc_x64: if vc_x64:
args.append('/dARCH=x64') args.append('/dARCH=x64')
if not version: if not version:
version = read_version_py(source_dir) version = read_version_py(source_dir)
args.append('/dVERSION=%s' % version) args.append('/dVERSION=%s' % version)
args.append('/dQUAD_VERSION=%s' % normalize_windows_version(version))
args.append('/Odist') args.append('/Odist')
args.append(str(inno_build_dir / 'mercurial.iss')) args.append(str(inno_build_dir / 'mercurial.iss'))
subprocess.run(args, cwd=str(source_dir), check=True) subprocess.run(args, cwd=str(source_dir), check=True)

contrib/packaging/inno/mercurial.iss

AppUpdatesURL=https://mercurial-scm.org/ AppUpdatesURL=https://mercurial-scm.org/
{{ 'AppID={{4B95A5F1-EF59-4B08-BED8-C891C46121B3}' }} {{ 'AppID={{4B95A5F1-EF59-4B08-BED8-C891C46121B3}' }}
AppContact=mercurial@mercurial-scm.org AppContact=mercurial@mercurial-scm.org
DefaultDirName={pf}\Mercurial DefaultDirName={pf}\Mercurial
SourceDir=stage SourceDir=stage
VersionInfoDescription=Mercurial distributed SCM (version {#VERSION}) VersionInfoDescription=Mercurial distributed SCM (version {#VERSION})
VersionInfoCopyright=Copyright 2005-2020 Matt Mackall and others VersionInfoCopyright=Copyright 2005-2020 Matt Mackall and others
VersionInfoCompany=Matt Mackall and others VersionInfoCompany=Matt Mackall and others
VersionInfoVersion={#QUAD_VERSION}
InternalCompressLevel=max InternalCompressLevel=max
SolidCompression=true SolidCompression=true
SetupIconFile=../mercurial.ico SetupIconFile=../mercurial.ico
AllowNoIcons=true AllowNoIcons=true
DefaultGroupName=Mercurial DefaultGroupName=Mercurial
PrivilegesRequired=none PrivilegesRequired=none
ChangesEnvironment=true ChangesEnvironment=true