This is an archive of the discontinued Mercurial Phabricator instance.

packaging: lowercase the `contrib` and `templates` directories with Inno
ClosedPublic

Authored by mharbison72 on Feb 1 2020, 1:48 AM.

Details

Summary

I have no idea why these (and contrib/vim) were leading with uppercase with
Inno, but not WiX. It probably doesn't matter too much, but might be a problem
with templates if the user enabled case sensitivity on NTFS.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Feb 1 2020, 1:48 AM

Did you test an upgrade over an existing install with this? My recollection is the case collision caused issues in my local testing, which is why I preserved the case difference between the installers.

I would love to converge on lowercase. So if this just works, I would be thrilled.

I just did Inno 5.0.2 -> current Inno without uninstalling, and I didn't see any errors. In this case, it preserves the existing capitalized names. But since we renamed help -> helptext, hgrc.d -> defaultrc, and since the previous installer cleanup this cycle did some things like rename Docs -> doc, it's probably a good idea to uninstall before upgrading. That said, it seemed like a functional installation (version and debuginstall worked). A subsequent uninstall removed the entire mess, not just the newly dropped files.

On a side note, I had put some ui.status() calls in to debug an unrelated problem, and that caused the __version__.py file to get a hex string in it somehow when building the installer, and that caused the new version parsing call that I added to explode. It works without that debugging, so just an FYI if you're building installers for testing purposes and leave extra output around. (I know the local hg is run to build that file and the output is captured, but I would have expected the extra output strings in there like I've seen before.)

indygreg accepted this revision.Feb 2 2020, 12:21 PM

OK. If an upgraded install works, I'm happy with landing this. We might as well land all the larger installer refactorings in this release. That should set us up for hopefully a less invasive switch to Python 3, as the install layouts will already be mostly identical.

This revision is now accepted and ready to land.Feb 2 2020, 12:21 PM